Skip to content

[ROCm] [Release] Update ROCm variant from rocm700 to rocm721#38413

Merged
tjtanaa merged 3 commits intovllm-project:mainfrom
tjtanaa:rocm721update
Mar 28, 2026
Merged

[ROCm] [Release] Update ROCm variant from rocm700 to rocm721#38413
tjtanaa merged 3 commits intovllm-project:mainfrom
tjtanaa:rocm721update

Conversation

@tjtanaa
Copy link
Copy Markdown
Collaborator

@tjtanaa tjtanaa commented Mar 28, 2026

Purpose

This is a follow up PR #38252

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

tjtanaa added 2 commits March 27, 2026 11:05
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Mar 28, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Mar 28, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ROCm variant from 7.0.0 to 7.2.1 in the Buildkite release pipeline and the wheel index generation script, and adds a condition to restrict nightly image publishing to nightly builds. A critical issue was identified where the Docker base image remains at version 7.0, creating an inconsistency that could result in mislabeled wheels and runtime failures.

Comment thread .buildkite/release-pipeline.yaml
@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2026
@tjtanaa tjtanaa enabled auto-merge (squash) March 28, 2026 04:24
@tjtanaa tjtanaa merged commit 58a249b into vllm-project:main Mar 28, 2026
13 of 14 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Mar 28, 2026
neweyes pushed a commit to neweyes/vllm that referenced this pull request Mar 31, 2026
…oject#38413)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: neweyes <328719365@qq.com>
puririshi98 pushed a commit to puririshi98/vllm that referenced this pull request Apr 7, 2026
…oject#38413)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: Rishi Puri <riship@nvidia.com>
mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants